Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): show 404 page for invalid URLs (#382) #382

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

mdonadoni
Copy link
Member

Closes #379

Copy link
Member

@giuseppe-steduto giuseppe-steduto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

(Needs rebasing)

@mdonadoni mdonadoni linked an issue Jan 12, 2024 that may be closed by this pull request
@mdonadoni mdonadoni changed the base branch from maint-0.9 to master January 15, 2024 08:44
@mdonadoni mdonadoni merged commit c18e81d into reanahub:master Jan 15, 2024
10 checks passed
@mdonadoni mdonadoni deleted the route-404-page branch January 15, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: 404 error page is not shown
2 participants