Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(launcher-badge): remove dollar sign in generated markdown #389

Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix(launcher-badge): remove dollar sign in generated markdown #389

merged 1 commit into from
Jan 24, 2024

Conversation

giuseppe-steduto
Copy link
Member

@giuseppe-steduto giuseppe-steduto commented Jan 19, 2024 •
edited
Loading

Closes #388

mdonadoni
mdonadoni reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@mdonadoni mdonadoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! But I think we agreed that it should be fix(launcher) and not fix(launcher-badge)?

@mdonadoni mdonadoni merged commit 8ad4afd into reanahub:master Jan 24, 2024
10 checks passed
@github-actions github-actions bot mentioned this pull request Jan 16, 2024
Merged
@mdonadoni mdonadoni mentioned this pull request Jan 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdonadoni mdonadoni mdonadoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in badge creator url
2 participants
@giuseppe-steduto @mdonadoni