-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(reana-dev): change run-example to use gherkin-parser module (#817) #817
feat(reana-dev): change run-example to use gherkin-parser module (#817) #817
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #817 +/- ##
===========================================
+ Coverage 19.22% 29.80% +10.57%
===========================================
Files 26 26
Lines 2512 2483 -29
===========================================
+ Hits 483 740 +257
+ Misses 2029 1743 -286
|
Add tests for gherkin-parser implementation of run-example.
PS: this PR needs to be rebased |
If a workflow throws an error while being tested (in run-example), it is now classified as failing
217a7c7
to
1e2967c
Compare
…nahub#817) Run-example now uses uses the test files in the specification file to check the correctness of the results (by running the test command).
Add tests for gherkin-parser implementation of run-example.
If a workflow throws an error while being tested (in run-example), it is now classified as failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
PS: Please add yourself to AUTHORS.md
! ;)
…eanahub#817) Also added myself to the AUTHORS file.
add18d5
to
759bb8b
Compare
…#817) Run-example now uses uses the test files in the specification file to check the correctness of the results (by running the test command).
…nahub#817) Run-example now uses uses the test files in the specification file to check the correctness of the results (by running the test command).
759bb8b
to
72bd76b
Compare
Run-example now uses the test files in the specification file to check the correctness of the results (by running the test command).