Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose backtrace filtering facilities #257

Open
wokalski opened this issue Jul 9, 2020 · 2 comments
Open

Expose backtrace filtering facilities #257

wokalski opened this issue Jul 9, 2020 · 2 comments

Comments

@wokalski
Copy link

wokalski commented Jul 9, 2020

When you write custom test DSLs you want to see expectation failures in your DSL code, not somewhere deep in a utility.
It'd be great to expose this filtering somewhere:
https://github.com/facebookexperimental/reason-native/blob/d3203eaeb05b49837fa85b1daed4b31390b64e27/src/rely/StackTrace.re#L125

@wokalski
Copy link
Author

wokalski commented Jul 9, 2020

I didn't have time to properly test it but I couldn't figure out what's the exclusion rule really. It seemed to work once and didn't work the other time (when I moved more of the DSL to a separate file).

@wokalski
Copy link
Author

wokalski commented Jul 9, 2020

Now that I think about it I know what was the issue. It proves this behavior is not enough 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant