Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix flaky test_spark_tuning #1769

Closed
miguelgfierro opened this issue Jul 1, 2022 · 1 comment
Closed

[BUG] Fix flaky test_spark_tuning #1769

miguelgfierro opened this issue Jul 1, 2022 · 1 comment
Labels
bug Something isn't working duplicate

Comments

@miguelgfierro
Copy link
Collaborator

Description

The test tests/unit/examples/test_notebooks_pyspark.py::test_spark_tuning is not working properly. See: #1764 (comment)

According to @anargyri: One thing that is special with this test in particular is that we call ALS.fit() two or three times. So, I would speculate that this may "overload" the resources allocated by Spark in some way. I suggest you try separating the ALS training runs into separate tests and see if this fixes the issue. It's probably feasible to do this by parameterizing the notebook in a creative way.

In which platform does it happen?

How do we replicate the issue?

More details https://github.com/microsoft/recommenders/runs/7145344779?check_suite_focus=true

Expected behavior (i.e. solution)

Other Comments

@miguelgfierro miguelgfierro added the bug Something isn't working label Jul 1, 2022
@miguelgfierro
Copy link
Collaborator Author

duplicate of #1770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate
Projects
None yet
Development

No branches or pull requests

1 participant