Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red5 Pro SDK filepath is wrong within code(Android) #66

Open
logandhead opened this issue Aug 12, 2020 · 3 comments
Open

Red5 Pro SDK filepath is wrong within code(Android) #66

logandhead opened this issue Aug 12, 2020 · 3 comments

Comments

@logandhead
Copy link

logandhead commented Aug 12, 2020

To install on android, you must manually edit a file to link the red5pro jar file. This seems to be a flaw because every time someone builds the node modules it requires you to go in every time to update the file path.

I'd suggest changing the code needing to be edited to:

dependencies {
    implementation "com.facebook.react:react-native:${safeExtGet('reactNativeVersion', '+')}"
    implementation files("../../../android/app/libs/red5streaming.jar") 
}

this will work for all react-native projects using the library because the file directory structure more than likely the same.

@logandhead logandhead changed the title Red5 Pro SDK filepath is wrong. Red5 Pro SDK filepath is wrong within code(Android) Aug 12, 2020
@chungweileong94
Copy link
Contributor

Currently, the best workaround for me is to use patch-package to handle the linking during the post-install.

@logandhead
Copy link
Author

Thanks @chungweileong9! Going to still keep open because I think that there should still be a fix to the source code and we should not be required to use patch-package.

@anmolsharma0002
Copy link

Execution failed for JetifyTransform: E:\web1experts\Galaxy\GalaxyApp\node_modules\react-native-red5pro\android\app\libs\red5streaming.jar.
> Transform's input file does not exist: E:\web1experts\Galaxy\GalaxyApp\node_modules\react-native-red5pro\android\app\libs\red5streaming.jar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants