From e54f2e4b76cd075cd33411d45895c8dcec2cb968 Mon Sep 17 00:00:00 2001
From: Takatoshi Kondo <redboltz@gmail.com>
Date: Tue, 7 May 2019 15:38:46 +0900
Subject: [PATCH] Replaced BOOST_ASSERT with overwrite.

It is corner case but BOOST_ASSERT is too strong.
Overwrite is better solution.
---
 include/mqtt/endpoint.hpp | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/include/mqtt/endpoint.hpp b/include/mqtt/endpoint.hpp
index 6591d60c7..f00ec088d 100644
--- a/include/mqtt/endpoint.hpp
+++ b/include/mqtt/endpoint.hpp
@@ -10172,7 +10172,24 @@ class endpoint : public std::enable_shared_from_this<endpoint<Socket, Mutex, Loc
                         control_packet_type::pubcomp,
                         msg
                     );
-                    BOOST_ASSERT(ret.second);
+                    // publish store is erased when pubrec is received.
+                    // pubrel store is erased when pubcomp is received.
+                    // If invalid client send pubrec twice with the same packet id,
+                    // then send corresponding pubrel twice is a possible client/server
+                    // implementation.
+                    // In this case, overwrite store_.
+                    if (!ret.second) {
+                        store_.modify(
+                            ret.first,
+                            [&] (auto& e) {
+                                e = store(
+                                    packet_id,
+                                    control_packet_type::pubcomp,
+                                    msg
+                                );
+                            }
+                        );
+                    }
                 }
 
                 if (serialize) {