-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added exportation from api/v2/constructed_inventories endpoint. #712
Added exportation from api/v2/constructed_inventories endpoint. #712
Conversation
… exportation for the smart inventories
0dfa0de
to
721196c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, need to be updated with base branch and a changelog fragment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we could fix the lint errors that would be great, not sure if you just need to ignore that file or why it is even linting a .py file honestly.
I'm fixing a lot of linter errors at #707 ... will try to rebase this one when the #707 is merged. In particular, I've added a |
With the other PR merged, can you rebase it, make sure it passes tests with the changes, otherwise looks good |
What does this PR do?
api/v2/constructed_inventories
endpoint.How should this be tested?
Manually tested. Automatic tests as well.
Is there a relevant Issue open for this?
N/A
Other Relevant info, PRs, etc
N/A