Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exportation from api/v2/constructed_inventories endpoint. #712

Conversation

ivarmu
Copy link
Contributor

@ivarmu ivarmu commented Oct 17, 2023

What does this PR do?

  • Add exportation from api/v2/constructed_inventories endpoint.
  • Add exportation for the smart inventories.

How should this be tested?

Manually tested. Automatic tests as well.

Is there a relevant Issue open for this?

N/A

Other Relevant info, PRs, etc

N/A

@ivarmu ivarmu force-pushed the filetree_create_export_constructed_inventories branch from 0dfa0de to 721196c Compare October 17, 2023 16:06
Copy link
Collaborator

@sean-m-sullivan sean-m-sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, need to be updated with base branch and a changelog fragment

Copy link
Contributor

@silvinux silvinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we could fix the lint errors that would be great, not sure if you just need to ignore that file or why it is even linting a .py file honestly.

@ivarmu
Copy link
Contributor Author

ivarmu commented Oct 31, 2023

if we could fix the lint errors that would be great, not sure if you just need to ignore that file or why it is even linting a .py file honestly.

I'm fixing a lot of linter errors at #707 ... will try to rebase this one when the #707 is merged. In particular, I've added a .ansible-lint-ignore file to avoid these .py files to be ansible-linted.

@sean-m-sullivan
Copy link
Collaborator

With the other PR merged, can you rebase it, make sure it passes tests with the changes, otherwise looks good

@sean-m-sullivan sean-m-sullivan merged commit f9ec9c7 into redhat-cop:devel Nov 2, 2023
13 checks passed
@ivarmu ivarmu deleted the filetree_create_export_constructed_inventories branch November 6, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants