Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: improve checkmode outputs #715

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

BobVanB
Copy link
Contributor

@BobVanB BobVanB commented Oct 20, 2023

Checkmode has workable and readable output in console.

This code adds mainly these features:

  • some labels to the output to make it readable.
  • Faster async with checkmode
  • Checkmode wil fail at the end of the dispatch, to make it faster to fix multiple issues and not 1 by 1.
  • workflow_launch.name is mandatory: workflow_launch_module.html#parameter-name

This is visible with a basic playbook command.

ansible-playbook --check ...

Is there a relevant Issue open for this?

Not Available

Other Relevant info, PRs, etc

@djdanielsson
Copy link
Collaborator

@sean-m-sullivan and/or @Tompage1994 thoughts? over all I didn't notice anything but want someone else to review as well

@sean-m-sullivan
Copy link
Collaborator

Can you check this, there are now a ton of conflicts as other changes were done to labels, this looks good, but better for you to check then one of us make a mistake

Copy link
Collaborator

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix conflicts @BobVanB

@BobVanB
Copy link
Contributor Author

BobVanB commented Nov 1, 2023

@djdanielsson i will do that. Will be tomorrow at best.

Copy link
Collaborator

@sean-m-sullivan sean-m-sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for these changes, and thanks for addressing the rebase!

@sean-m-sullivan sean-m-sullivan merged commit a20e97c into redhat-cop:devel Nov 2, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants