Fix usage of compare_list_reduced variable #721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The object diff plugin used the wrong variable in 1 place when using
with_present
.When using that option, the
state: present
key is added to thecompare_list_reduced
dict, however, thecompare_list
was then extended and returned.This also solves removing too much differences based on the if-statement on line 332 as less dict now have less than 3 keys
How should this be tested?
Manual
{"controller_roles": [{"team": "dummy", "job_template": "dummy_template", "role": "read"}]
include_present_state: true
state: present
key. Before it did notIs there a relevant Issue open for this?
Other Relevant info, PRs, etc