Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calling manifest when manifest_url is defined #725

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

rdrazny
Copy link
Contributor

@rdrazny rdrazny commented Nov 13, 2023

What does this PR do?

PR #704 added a fix for manifest_content, but manifest_url is still ignored. manifest.yml is still not included when manifest_url is defined.

How should this be tested?

Manual test only.

Is there a relevant Issue open for this?

No.

Other Relevant info, PRs, etc

#704

Copy link
Collaborator

@sean-m-sullivan sean-m-sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM, however going to have to peek under the hood to figure out if the test failures are from this or not, I don't think they are but want to double check.

@rdrazny
Copy link
Contributor Author

rdrazny commented Nov 14, 2023

Good catch, LGTM, however going to have to peek under the hood to figure out if the test failures are from this or not, I don't think they are but want to double check.

Looks like content_objects "Survey Template with vars no org" and "workflow_test_template" have switched order in the actual output, and that's enough to throw the diff module off.

@ivarmu
Copy link
Contributor

ivarmu commented Nov 15, 2023

I think replaying the failed jobs will work ok. It may be caused by a temporary connection issues when fetching the objects from the API. Also... only two of the test jobs are failing... it doesn't seem to be a real error in the code...

@ivarmu ivarmu enabled auto-merge (squash) November 16, 2023 13:23
@sean-m-sullivan sean-m-sullivan merged commit 7aec995 into redhat-cop:devel Nov 19, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants