Bugfix: Allow to omit "source" parameter for role inventory_sources #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djdanielsson
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
a79f987 had a bug: It does not allow to omit the source parameter anymore, because it is evaluated before applying the default.
This PR fixes that by applying the same default as above a few lines above.
Honestly: A cleaner solution would be to revert a79f987 and then take the time to implement this in a better way. Because with my PR the default is redundant. It is still better than having a bug in the code, I should say.
How should this be tested?
Is there a relevant Issue open for this?
resolves #738
Other Relevant info, PRs, etc