Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification templates option assign option to organization role #778

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

Tompage1994
Copy link
Collaborator

@Tompage1994 Tompage1994 commented Mar 13, 2024

What does this PR do?

  • Add assign_notification_templates_to_org option to organization role to allow conditional assigning of notification templates
  • Updated dispatch role with assign_notification_templates_to_org option assigned to organization as False on first run and True on second run by default.
  • Updated the arg_spec for dispatch to reflect the current truth

How should this be tested?

I've updated CI to test for this and also test for galaxy credential assigning. Added this test case:

  - name: Test-dispatch-dependencies
    galaxy_credentials:
      - galaxy-server
    notification_templates_approvals:
      - Email notification

Is there a relevant Issue open for this?

resolves #765

Other Relevant info, PRs, etc

N/A

@Tompage1994 Tompage1994 force-pushed the 765-notif-temp-dispatch branch 5 times, most recently from 67814e0 to 0926649 Compare March 13, 2024 16:15
Copy link
Collaborator

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tompage1994 Tompage1994 force-pushed the 765-notif-temp-dispatch branch 2 times, most recently from e9f4125 to a43e91a Compare March 13, 2024 16:49
@djdanielsson djdanielsson merged commit c2e6772 into redhat-cop:devel Mar 14, 2024
13 checks passed
@jon4hz
Copy link
Contributor

jon4hz commented Mar 14, 2024

Thanks a lot for implementing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dispatch: Unable to create organisation and notification template in the same run
3 participants