Update current_inventory_sources.j2 to fix the empty credential scenario #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tompage1994
reviewed
Apr 15, 2024
| @@ -22,7 +22,7 @@ controller_inventory_sources: | |||
| inventory: "{{ inventory_source.summary_fields.inventory.name }}" | |||
| update_on_launch: "{{ inventory_source.update_on_launch }}" | |||
| overwrite: "{{ inventory_source.overwrite }}" | |||
| {% if inventory_source.credential is defined %} | |||
| {% if inventory_source.credential is defined and inventory_source.summary_fields.credential is defined %} | |||
There was a problem hiding this comment.
This logic still seems slightly wrong here. Should it not just be if inventory_source.summary_fields.credential is defined? Perhaps should the value set be different if it is inventory_source.credential defined?
There was a problem hiding this comment.
Yeah, you are right.
I didn't remove the original check as I thought its good to have a double check :)
Feel free to amend it and proceed.
Thanks in advance
Tompage1994
requested changes
Apr 15, 2024
|
adonisgarciac
approved these changes
Apr 15, 2024
Tompage1994
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is related to the issue #811.
If no credential is assigned to the inventory sources, still the
inventory_source.credentialwill be defined but with[]value. Which will cause an issue as the actualinventory_source.summary_fields.credentialwill be empty. So need to ensure theinventory_source.summary_fields.credentialis also defined and not empty.How should this be tested?
Is there a relevant Issue open for this?
Resolves #811.
Other Relevant info, PRs, etc
Changelog
undefiedvalue.