instance group skip option when creating orgs #859
Conversation
modified: roles/organizations/tasks/main.yml
|
untested |
modified: plugins/modules/controller_export_diff.py modified: roles/organizations/tasks/main.yml
|
Hi @djdanielsson, I think you should add assign_instance_groups_to_org control var to dispatch role: https://github.com/redhat-cop/controller_configuration/blob/devel/roles/dispatch/tasks/main.yml#L12-L15 |
|
the instance groups are created before the orgs in dispatch so I do not think it is needed @adonisgarciac |
|
you're right @djdanielsson. Then, I guess these changes are not solving #858. I think the problem in that issue is that they want to add a Instance Group/ container group (with a Credential for k8s/ocp) and Credentials are created after instance group and after organizations: "The reason is the dependency cycle: Organization -> Instance Group -> Credential -> Organization." I mean, the problem is not when organizations with IG are created (because IG are created before). If I'm not mistaken, the actual issue is when a IG with credential is created but that credential is not present yet: |
|
there may be a need to change when instance groups are created, but that is not related to this. not everyone uses dispatch nor will it work for every configuration. The request was to add an option to skip instance groups when creating orgs which this does |
|
Great! BTW, any reason why 2.8.1 is still not available in galaxy.ansible.com 2 months release ? |
What does this PR do?
attempt to add the option to skip instance_group assignment to org until it can be created.
How should this be tested?
manual at first maybe add automated later
Is there a relevant Issue open for this?
resolves #858
Other Relevant info, PRs, etc