Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Enable multi-arch build for mapt #311

Open
adrianriobo opened this issue Oct 15, 2024 · 3 comments
Open

[Enhancement] Enable multi-arch build for mapt #311

adrianriobo opened this issue Oct 15, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request size/M

Comments

@adrianriobo
Copy link
Collaborator

Currently mapt and oci container is built only for x86 it should be built for multi-arch

@adrianriobo adrianriobo added enhancement New feature or request size/M labels Oct 15, 2024
@adrianriobo adrianriobo changed the title [enhancement] Enable multi-arch build for mapt [Enhancement] Enable multi-arch build for mapt Oct 15, 2024
@adrianriobo
Copy link
Collaborator Author

adrianriobo commented Oct 15, 2024

Here there is a sample on how we manage this on other project:

Makefile for build and aggreagate to manifest
https://github.com/crc-org/ci-definitions/blob/71d9c0cc3371aec456fbb5c048cb8c6cd52c8e0a/Makefile#L66

Containerfile with target arch arg to manage the container assets arch properly
https://github.com/crc-org/ci-definitions/blob/main/crc-builder/oci/Containerfile.linux#L4

@lilyLuLiu lilyLuLiu self-assigned this Oct 15, 2024
@adrianriobo
Copy link
Collaborator Author

Hey @lilyLuLiu I actually open an issue crc-org/ci-definitions#32 as it seems this is not working as expected...mainly due to the strategy required for forked repos.

We basically create those images on the forked repo (as long as they are not tagged versions) then save as tar upload as artifacts and from the upstream context load and push to internal ghcr.

But it seems that save operation does not allow us to do the multiarch

containers/podman#22882

@adrianriobo
Copy link
Collaborator Author

To make the builded pusher strategy works there is a tricky thing needed to make in order to save images you can see https://github.com/crc-org/ci-definitions/pull/34/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M
Projects
None yet
Development

No branches or pull requests

2 participants