Support group in devfile commands (application lifecycle)

[elsony]

/kind user-story

User Story

As a stack creator, I want to define the group that a given command in a devfile belongs to so that odo know what default command to when it build, run, test and debug.

Acceptance Criteria

• It should follow the corresponding settings specified in the devfile 2.0 specification: Command group (application lifecycle) devfile/api#27
• It should support setting default for each group (see spec above)
• It should replace the existing devBuild and devRun commands on the push logic
• It should modify the existing odo catalog list components logic acceptance criteria to use the group info instead of the odo specific devBuild and devRun commands

Links

• Related issue: Command group (application lifecycle) devfile/api#27

/kind user-story
/area devfile

[kadel]

this is blocked on #2918, the parser needs to be implemented first

/stats blocked

[kadel]

• It should replace the existing devBuild and devRun commands on the push logic

@elsony What about devfile v1 support. Are we not going to support it anymore?

[maysunfaisal]

Some observations for this work to be completed:

• If there are multiple group commands without a default, it should err out
• there needs to be one run group command defined, otherwise it should err out
• build group command optional like devfile v1

[elsony]

Some observations for this work to be completed:

* If there are multiple group commands without a default, it should err out

* there needs to be one run group command defined, otherwise it should err out

* build group command optional like devfile v1

I would suggest to modify slightly to clarify:

1. If there are multiple group commands without a default, it should err out. This check is only done for the groups that odo consumes and the check is done when doing the corresponding execution, e.g. check on debug group only if running odo push with --debug
2. there needs to be at least one run group command defined, otherwise it should err out during odo push. Rule for multiple run command in point Use oc binary instead client-go for initial implementation #1 still applies.
3. build group command optional like devfile v1

[maysunfaisal]

@elsony what do you think about this issue here regarding command groups #3216 (comment)

[kadel]

• It should modify the existing odo catalog list components logic acceptance criteria to use the group info instead of the odo specific devBuild and devRun commands

I think that we should list all devfiles in the registry regardless of what command groups are there.
Users can still use --run-command and --build-command to select the right commands if they are not specified in the devfile.

[maysunfaisal]

@kadel that is true. But odo push would fail if there are no build and run groups at this point. Is it a good UX to enable this by default registry? 🤔

[kadel]

@kadel that is true. But odo push would fail if there are no build and run groups at this point. Is it a good UX to enable this by default registry? 🤔

The default registry is under our control, so we can make sure that all devfiles in the default registry have proper groups.