Devfile v2 issue: Should not give error if other than exec command types present in devfile

[cdrage]

/kind bug

What versions of software are you using?

Operating System:

Output of odo version:

How did you run odo exactly?

~/openshift/f                                                                                                                                                                                                                                                                                                                                                               
▶ odo create foo --devfile https://raw.githubusercontent.com/devfile/kubernetes-api/master/devfile-support/samples/simple-devfile.yaml
Experimental mode is enabled, use at your own risk

Validation
 ✓  Creating a devfile component from devfile path: https://raw.githubusercontent.com/devfile/kubernetes-api/master/devfile-support/samples/simple-devfile.yaml [29040ns]
 ✓  Validating devfile component [66356ns]                                                                                                                                                                                                                                                                                                                                  
 
Please use `odo push` command to create the component with source deployed

~/openshift/f                                                                                                                                                                                                                                                                                                                                                               
▶ odo push

Validation
 ✗  Validating the devfile [86168ns]
 ✗  Failed to start component with name foo. Error: Failed to create the component: failed to validate devfile build and run commands: command must be of type "exec"%!!(MISSING)(EXTRA string=
)command must be of type "exec"%!!(MISSING)(EXTRA string=
)

See below YAML:

  - exec:
      id: helloWorld
      env:
        - name: "USER"
          value: "John Doe"
      commandLine: 'echo "Hello ${USER}"'

I have a feeling it's from using quotes within the command. Or this here:

  - composite:
      id: buildSchemaAndOpenDevfile
      label: Build schema and open devfile
      commands:
        - buildSchema
        - openDevfile
      parallel: false

Actual behavior

Failure when deploying

Expected behavior

Being able to crrectly deploy with exec command

Any logs, error output, etc?

[mik-dass]

• composite:
  id: buildSchemaAndOpenDevfile
  label: Build schema and open devfile
  commands:
  - buildSchema
  - openDevfile
  parallel: false

We don't support composite type of commands. There is a issue regarding support of composite commands #3338

[adisky]

@cdrage yes we do not support composite commands, but it is a valid bug, IMO we should not error out if other types of command is present. This needs to be updated here
https://github.com/openshift/odo/blob/edc7c336973c3978d3e8cadfee99e1c3dff2b91c/pkg/devfile/adapters/common/command.go#L94

[kadel]

/close
/triage duplicate

Composite commands will be implemented in #3338

[openshift-ci-robot]

@kadel: Closing this issue.

In response to this:

/close
/triage duplicate

Composite commands will be implemented in #3338

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.