Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement hotReloadCapable flags from devfile v2 spec #3548

Closed
kadel opened this issue Jul 13, 2020 · 5 comments · Fixed by #3785
Closed

Implement hotReloadCapable flags from devfile v2 spec #3548

kadel opened this issue Jul 13, 2020 · 5 comments · Fixed by #3785
Assignees
@adisky
Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). v2 Issue or PR that applies to the v2 of odo

Comments

@kadel
Copy link
Member

kadel commented Jul 13, 2020 •
edited
Loading

devfile/api#64

Let's implement support for restartOnChange field as defined in the above issue

/triage needs-information
@kadel kadel added triage/needs-information Indicates an issue needs more information in order to work on it. required-for-v2 priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). labels Jul 13, 2020
@kadel
Copy link
Member Author

kadel commented Jul 14, 2020

I've just opened PR to add those fields to devfile v2 spec devfile/api#96

@adisky
Copy link
Contributor

adisky commented Jul 15, 2020

@kadel little confused on backgroud flag, we determine the process has to be run in background by its kind (I believe kind is for this purpose), am i missing some motive behind adding the background flag?

@kadel kadel changed the title Implement restartOnChange and background flags from devfile v2 spec Implement restartOnChange flags from devfile v2 spec Jul 15, 2020
@dharmit
Copy link
Member

dharmit commented Jul 15, 2020

Scope of this issue is only for restartOnChange. background will be handled separately.

@kadel kadel removed the triage/needs-information Indicates an issue needs more information in order to work on it. label Jul 15, 2020
@dharmit dharmit added points/3 triage/needs-information Indicates an issue needs more information in order to work on it. labels Jul 15, 2020
@kadel
Copy link
Member Author

kadel commented Jul 15, 2020

Scope of this issue is only for restartOnChange. background will be handled separately.

Opened separate issue for background #3580

@girishramnani girishramnani added the status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) label Aug 4, 2020
@kadel
Copy link
Member Author

kadel commented Aug 17, 2020

PR devfile/api#96 got merged

Please note that the field was renamed to hotReloadCapable

/remove-status blocked

@adisky adisky removed the status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) label Aug 17, 2020
@adisky adisky mentioned this issue Aug 19, 2020
Merged
3 tasks
@girishramnani girishramnani changed the title Implement restartOnChange flags from devfile v2 spec Implement hotReloadCapable flags from devfile v2 spec Aug 20, 2020
@girishramnani girishramnani added triage/ready and removed triage/needs-information Indicates an issue needs more information in order to work on it. labels Aug 21, 2020
@prietyc123 prietyc123 added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Aug 26, 2020
@rm3l rm3l added the v2 Issue or PR that applies to the v2 of odo label Jun 18, 2023
@rm3l rm3l added this to odo Project Jun 18, 2023
@rm3l rm3l moved this to Done ✅ in odo Project Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adisky adisky

Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). v2 Issue or PR that applies to the v2 of odo
Projects
odo Project
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for hot reload commands adisky/odo
6 participants
@kadel @rm3l @dharmit @girishramnani @adisky @prietyc123