Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove integer and boolean required properties #152

Closed
xorye opened this issue Nov 26, 2019 · 1 comment · Fixed by #169
Closed

Remove integer and boolean required properties #152

xorye opened this issue Nov 26, 2019 · 1 comment · Fixed by #169
Assignees
@xorye
Labels
enhancement New feature or request properties Features supported in application.properties
Milestone
v0.0.5

Comments

@xorye
Copy link

xorye commented Nov 26, 2019 •
edited
Loading

If a config item is a int or boolean type, and do not have a default value specified with the @ConfigItem annotation (ex. @ConfigItem(defaultValue = 0)), they implicitly have a value of 0 and false respectively.

This means that integers and booleans are not required properties because they have a value to fall back on.
@fbricon fbricon added properties Features supported in application.properties enhancement New feature or request labels Nov 28, 2019
@fbricon fbricon added this to the v0.0.5 milestone Nov 28, 2019
@xorye
Copy link
Author

xorye commented Nov 28, 2019

If a config item is a int or boolean type, and do not have a default value specified with the @configitem annotation (ex. @configitem(defaultValue = 0)), they implicitly have a value of 0 and false respectively.

Just to clarify, this is only for the @ConfigItem annotation. @angelozerr From ExtendedConfigDescriptionBuildItem can we determine what annotation the config had?

@xorye xorye mentioned this issue Dec 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xorye xorye

Labels
enhancement New feature or request properties Features supported in application.properties
Projects
None yet
Milestone
v0.0.5
Development

Successfully merging a pull request may close this issue.

Set default values for bool and int @ConfigItem properties
2 participants
@fbricon @xorye