Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor unit tests so that they can be reused for validating alternate IJDTUtils implementations #187

Closed
jeffmaury opened this issue Jan 8, 2020 · 2 comments · Fixed by #258
Closed

Refactor unit tests so that they can be reused for validating alternate IJDTUtils implementations #187

jeffmaury opened this issue Jan 8, 2020 · 2 comments · Fixed by #258
Assignees
@jeffmaury
Labels
enhancement New feature or request good first issue Good for newcomers quarkus-jdt-extension
Milestone
v0.0.6

Comments

@jeffmaury
Copy link
Member

As jbosstools-quarkus implements IJDTUtils based on JDT and not JDT.LS it would be good if we can reuse the existing unit tests for validating this alternate IJDTUtils implementation
@jeffmaury jeffmaury added enhancement New feature or request good first issue Good for newcomers quarkus-jdt-extension labels Jan 8, 2020
@jeffmaury jeffmaury self-assigned this Jan 8, 2020
@fbricon
Copy link
Collaborator

fbricon commented Mar 11, 2020

@jeffmaury any short term plans for this one?

@jeffmaury
Copy link
Member Author

No found the issues that tests are fragments and it causes issues when trying to reuse and didn't managed to find time to go next

@jeffmaury jeffmaury linked a pull request Mar 23, 2020 that will close this issue
Refactor unit test so that they can be reused #258
Merged
@angelozerr angelozerr added this to the v0.0.6 milestone Mar 23, 2020
@jeffmaury jeffmaury mentioned this issue Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffmaury jeffmaury

Labels
enhancement New feature or request good first issue Good for newcomers quarkus-jdt-extension
Projects
None yet
Milestone
v0.0.6
Development

Successfully merging a pull request may close this issue.

Refactor unit test so that they can be reused jeffmaury/quarkus-ls
3 participants
@fbricon @jeffmaury @angelozerr