Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Need to verify if rh-che is stable with the upstream CHE_CORE_JSONRPC setting and 1 GB of RAM #1337

Closed
ibuziuk opened this issue Mar 28, 2019 · 10 comments

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Mar 28, 2019

PR introduced a few changes of CHE_CORE_JSONRPC which are most likely not needed and upstream values can be safely used - #1323

CHE_CORE_JSONRPC_MINOR__PROCESSOR__CORE__POOL__SIZE: '5'
CHE_CORE_JSONRPC_MINOR__PROCESSOR__MAX__POOL__SIZE: '100'
CHE_CORE_JSONRPC_MINOR__PROCESSOR__QUEUE__CAPACITY: '1000'
CHE_CORE_JSONRPC_PROCESSOR__CORE__POOL__SIZE: '30'
CHE_CORE_JSONRPC_PROCESSOR__MAX__POOL__SIZE: '100'
CHE_CORE_JSONRPC_PROCESSOR__QUEUE__CAPACITY: '500000'

Need to verify if che.openshift.io works stable without sideeffects with 1Gb of RAM and upstream settings of CHE_CORE_JSONRPC.

@ScrewTSW
Copy link
Member

About default upstream values, I was able to cause the OOM crash on upstream defaults as well. They will require some tweaking (namely message queue size)

@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 28, 2019

cc: @skabashnyuk ^ wdyt shoud upstream values be adjusted. IMO it would be great if che.openshift.io would use upstream setup for RAM / CHE_CORE_JSONRPC

@skabashnyuk
Copy link
Collaborator

I agree with @ScrewTSW CHE_CORE_JSONRPC_PROCESSOR__QUEUE__CAPACITY has to be adjusted to fit in the 1G limit. @ScrewTSW what would be your suggestion?

@ScrewTSW
Copy link
Member

ScrewTSW commented Apr 2, 2019

I agree with @ScrewTSW CHE_CORE_JSONRPC_PROCESSOR__QUEUE__CAPACITY has to be adjusted to fit in the 1G limit. @ScrewTSW what would be your suggestion?

I would try 200k at most. I think 150k is the safer value here.

@ibuziuk
Copy link
Member Author

ibuziuk commented Apr 2, 2019

@ScrewTSW are you planning to provide upstream PR for review as part of this issue?

@skabashnyuk
Copy link
Collaborator

Already doing some adjustment eclipse-che/che#13034

@ibuziuk
Copy link
Member Author

ibuziuk commented Apr 2, 2019

@skabashnyuk wdyt, once the adjustments are done upsteam - does it makes sense to fall back on those defaults in rh-che?

@skabashnyuk
Copy link
Collaborator

Some data from real-life server
Знімок екрана 2020-03-02 о 11 23 12
Знімок екрана 2020-03-02 о 11 22 11
I think upstream defaults should be enaught for this type of load.

# Maximum size of the JSON RPC processing pool
# in case if pool size would be exceeded message execution will be rejected
che.core.jsonrpc.processor_max_pool_size=50

# Initial json processing pool. Minimum number of threads that used to process major JSON RPC messages.
che.core.jsonrpc.processor_core_pool_size=5

@skabashnyuk skabashnyuk assigned ScrewTSW and rhopp and unassigned tdancs, ScrewTSW and rhopp Mar 2, 2020
@ibuziuk ibuziuk added this to the 7.14.0 milestone May 13, 2020
@ibuziuk ibuziuk changed the title Need to verify if rh-che is stable wit upstream CHE_CORE_JSONRPC setting and 1 GB of RAM Need to verify if rh-che is stable with the upstream CHE_CORE_JSONRPC setting and 1 GB of RAM Jun 3, 2020
@ibuziuk ibuziuk modified the milestones: 7.14.0, 7.15.0 Jun 3, 2020
@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 22, 2020

PR sent - #1927

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 23, 2020

applied on production

@ibuziuk ibuziuk closed this as completed Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants