Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode does not show type hierarchy on maven multi module #2871

Closed
clembo590 opened this issue Jan 11, 2023 · 5 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#2404
Closed
Assignees
Labels

Comments

@clembo590
Copy link

Environment
  • Operating System: macos 13.0.1
  • JDK version: 17
  • Visual Studio Code version: Version: 1.74.2
  • Java extension version: java extension pack v0.25.7
Steps To Reproduce

Steps To Reproduce
I have created a public repo so that the issue is easily reproducible:

step1: clone this repo:

git clone https://github.com/clembo590/issues.git --branch vscode-class-hierarchy-issue

step2: run mvn clean install
-->no issue

step 3: open the project in vscode

step4: open class called First and perform show type hierarchy

--> The error is that vscode does not show Second as a subclass of First AND IT SHOULD!

Step 5: move Second.java to the same folder than First.java and perform a show type hierarchy on First.java

--> This time the hierarchy is correct.

Type hierarchy works on a single maven module but not on multimodules.

Here is gif
anim

@CsCherrYY
Copy link
Contributor

I can reproduce this issue in eclipse, looks like an upstream jdt issue.

image

@rgrunber
Copy link
Member

Seems similar to #2219 . Maybe we can narrow it down more easily with this particular example ?

@snjeza
Copy link
Contributor

snjeza commented Jan 15, 2023

I can't reproduce the issue in Eclipse JDT master
jdt2871

It is reproducible in VS Code even with the jdt master..

@snjeza snjeza removed the upstream label Jan 15, 2023
@rgrunber
Copy link
Member

It also works for me upstream. I tried with Eclipse 4.25 (2022-09) & 4.26 (2022-12) making sure to install the corresponding version of M2E support. I noticed 4.25 didn't recognize the project as Maven but did detect it on build (and added the correct decorations in the package explorer).

If it's reproducible in vscode-java every time, then let's start with that and see where things are going wrong.

@clembo590
Copy link
Author

Thanks a lot I confirm that the bug is now fixed!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants