Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighting is wrong #707

Closed
V0idk opened this issue Nov 5, 2018 · 2 comments
Closed

Highlighting is wrong #707

V0idk opened this issue Nov 5, 2018 · 2 comments
Assignees
@snjeza
Labels
bug highlighting upstream
Milestone
End April 2020

Comments

@V0idk
Copy link

V0idk commented Nov 5, 2018

image
@fbricon
Copy link
Collaborator

fbricon commented Nov 6, 2018

Syntax highlighting is provided by vscode proper, which itself depends on the atom grammar. So it needs to be fixed there first

This was referenced Nov 26, 2018
Closed
Closed
@fbricon fbricon added the bug label Nov 29, 2018
This was referenced Apr 20, 2020
Closed
Merged
@fbricon fbricon added this to the End April 2020 milestone Apr 27, 2020
@fbricon
Copy link
Collaborator

fbricon commented Apr 27, 2020

This is partially fixed with the new semantic highlighting support in vscode-java 0.61.0. Requires "java.semanticHighlighting.enabled": true in settings.json. Without semantic highlighting, the Textmate grammar is still broken.

@fbricon fbricon closed this as completed Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snjeza snjeza

Labels
bug highlighting upstream
Projects
None yet
Milestone
End April 2020
Development

Successfully merging a pull request may close this issue.

Wrong highlighting in member-variables snjeza/language-java
3 participants
@fbricon @snjeza @V0idk