Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to use higher version of tkn with warning. #116

Closed
sudhirverma opened this issue Dec 20, 2019 · 4 comments · Fixed by #118
Closed

Allow user to use higher version of tkn with warning. #116

sudhirverma opened this issue Dec 20, 2019 · 4 comments · Fixed by #118
Assignees
Milestone

Comments

@sudhirverma
Copy link
Contributor

If the user has a newer version of tkn cli available, and do not want to download an older version from extension then show the warning message that the user has a newer version and extension may not work 100% correctly.

@sudhirverma sudhirverma added this to the devex #177 milestone Dec 20, 2019
@sudhirverma sudhirverma self-assigned this Dec 20, 2019
@siamaksade
Copy link

A warning should suffice, without blocking the extension to issue tkn comments with the whatever tkn version that is installed on user's workstation.

Is it possible to display this warning when a tkn command does not work as expected, rather than upfront?

@sudhirverma
Copy link
Contributor Author

@siamaksade we will show the warning message upfront of the extension. while running tkn command in case of failure/command doesn't work as accepted we will show the same message as provided by tkn command.

cc: @dgolovin @evidolob WDYT.

@evidolob
Copy link
Collaborator

I think we can show warning when we detect version of tkn if installed cli has bigger version, there:

public static async selectTool(locations: string[], versionRange: string): Promise<string> {

while running tkn command in case of failure/command doesn't work as accepted we will show the same message as provided by tkn command.

It is a good idea.

@dgolovin
Copy link
Contributor

dgolovin commented Jan 8, 2020

Related to #73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants