Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI not found error message #130

Closed
siamaksade opened this issue Jan 15, 2020 · 3 comments
Closed

Update CLI not found error message #130

siamaksade opened this issue Jan 15, 2020 · 3 comments
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@siamaksade
Copy link

The current error message when the Tekton CLI is not found is:

Cannot find A CLI for interacting with Tekton v0.6.0.

Tekton v0.6.0 is in correct given that 0.6.0 is the version of the CLI. It should possibly say instead:

Cannot find Tekton CLI v0.6.0 for interacting with Tekton Pipelines. 
@evidolob evidolob self-assigned this Jan 15, 2020
@evidolob
Copy link
Collaborator

We need to handle that by changing regexp

const version = new RegExp(`^Client version:\\s([0-9]+\\.[0-9]+\\.[0-9]+)$`);
to have optional v before version.
tektoncd/cli#604

@siamaksade
Copy link
Author

This is just about the wording of the error message. Tekton CLI v0.6.0 vs Tekton 0.9

@evidolob
Copy link
Collaborator

Yes, sorry. Message fixed with this commit 8bb4883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants