Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize LSP definition #212

Open
angelozerr opened this issue Jan 7, 2020 · 2 comments
Open

Customize LSP definition #212

angelozerr opened this issue Jan 7, 2020 · 2 comments

Comments

@angelozerr
Copy link

By following the great explanation how to contibute with YAML schema I have copied/pasted https://github.com/Azure/vscode-kubernetes-tools/blob/127ec070c8dabd56901ce13ff81bd6f561e4f087/src/yaml-support/yaml-schema.ts#L24 and adapted it for Quarkus. I can manage completion, validation, hover for Quarkus properties in application.yaml:

QuarkusYamlDemo

The missing feature is about definition (hyperlink). I would like to do a Ctrl+Click on name child to open the Java class which defines this property (like we have with application.properties).

It should be fantastic if yaml language server could give this capability.

@gorkem
Copy link
Collaborator

gorkem commented Jan 10, 2020

The way to add functionality such as this is supporting it through the JSON schema. Of course standard JSON schema spec, does not have anything related but the JSON Schema that YAML LSP is using is JSON Schema with extensions. YAML LS needs a bit of work (#150) before we can consider more extensions but the way to extend YAML LS is to extend the JSON Schema with extensions.

@safareli
Copy link

Any updates on this? How can one contribute on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants