Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag 3.2 doesn't run with --protected-mode no with persistent storage or other args #58

Closed
nrktkt opened this issue May 10, 2016 · 0 comments

Comments

@nrktkt
Copy link

nrktkt commented May 10, 2016

Expected behavior:
Redis runs in docker container in unprotected mode.

Actual behavior:
Starting the container with redis-server --appendonly yes (or probably any other explicit arguments) causes redis to start in protected mode.

Details:
When running the redis docker image from tag 3.2 with docker run --name token-redis -p ${MY_PORT}:6379 -d redis:3.2 redis-server --appendonly yes the following error is produced.

Error: DENIED Redis is running in protected mode because protected mode is enabled, no bind address was specified, no authentication password is requested to clients. In this mode connections are only accepted from the loopback interface. If you want to connect from external computers to Redis you may adopt one of the following solutions: 1) Just disable protected mode sending the command 'CONFIG SET protected-mode no' from the loopback interface by connecting to Redis from the same host the server is running, however MAKE SURE Redis is not publicly accessible from internet if you do so. Use CONFIG REWRITE to make this change permanent. 2) Alternatively you can just disable the protected mode by editing the Redis configuration file, and setting the protected mode option to 'no', and then restarting the server. 3) If you started the server manually just for testing, restart it with the '--protected-mode no' option. 4) Setup a bind address or an authentication password. NOTE: You only need to do one of the above things in order for the server to start accepting connections from the outside. channel: [id: 0x8d7ec4dc, /192.168.99.1:52640 => /192.168.99.101:6379] data: null

The explicit arguments override the CMD in the dockerfile which disables protected mode.

Suggestion:
If the intention is to always disable protected mode (makes sense) then move --protected-mode no to docker-entrypoint.sh so that it always runs, even with over-ridden CMD.
If the intention is to allow the container to be run with protected mode, then update the docs on docker hub (specifically under the header start with persistent storage) to indicate that --protected-mode no also needs to be provided.

@nrktkt nrktkt changed the title Tag 3.2 doesn't respect --protected-mode no with persistent storage Tag 3.2 doesn't run with --protected-mode no with persistent storage or other args May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant