Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESP 2/3 should be part of goredis.Options #2152

Open
filipecosta90 opened this issue Jul 12, 2022 · 1 comment
Open

RESP 2/3 should be part of goredis.Options #2152

filipecosta90 opened this issue Jul 12, 2022 · 1 comment

Comments

@filipecosta90
Copy link
Contributor

filipecosta90 commented Jul 12, 2022

Currently, the v9 go-redis version is always trying to use RESP3 and in case of failure, it will fall back to resp2.
However, even on scenarios that the server supports resp 3, there are some considerations ( performance for example, or controlling the reply type ) in which we want to be able to chose.
Furthermore, in the event of old server/servers that don't support it, it's expensive to continuously pay the network and CPU for something that the user knows beforehand will fail.

@chayim
Copy link
Contributor

chayim commented Feb 9, 2023

Remember to consider redis/redis-specifications#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants