Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mingw cross compilation error #1126

Closed
bit0fun opened this issue Oct 27, 2022 · 4 comments
Closed

Mingw cross compilation error #1126

bit0fun opened this issue Oct 27, 2022 · 4 comments

Comments

@bit0fun
Copy link

bit0fun commented Oct 27, 2022

I'm working on cross compiling hiredis on linux to windows with mingw, and found that in sockcompat.h:53, mingw will fail compilation due to Mstcpip.h not being found

Simply changing this to mstcpip.h, compilation succeeds on the master branch without issue.
I didn't want to create a pull request for this change before creating an issue, because I'm not sure if this would affect anything else.

I'm assuming that given windows doesn't care about case for file names that this would not be a problem, but I don't have a development environment for windows to test this out.

@michael-grunder
Copy link
Collaborator

Feel free to open a PR and I'll authorize a CI run.

As you said, it's probably fine as Windows is case-insensitive when it comes to filenames.

@bit0fun
Copy link
Author

bit0fun commented Oct 27, 2022

It's such a small change I doubt it would be an issue, but just wanted to check first

Thanks for the quick response! Give me a few and I'll make the pr

@bit0fun
Copy link
Author

bit0fun commented Oct 27, 2022

Almost made identical PR and issue numbers haha

Here's the PR: #1127

@michael-grunder
Copy link
Collaborator

Closing via #1127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants