Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit() on OOM #3

Closed
minaguib opened this issue Aug 16, 2010 · 1 comment
Closed

exit() on OOM #3

minaguib opened this issue Aug 16, 2010 · 1 comment

Comments

@minaguib
Copy link

Hi

In a few places, if hiredis gets out of memory, it calls exit()

This is unlikely, however since hiredis is a library, I'd like it if program control is dictated by the caller.

I think functions that OOM should just return failure to the user. Alternatively, the user at init time can supply a pointer to his own OOM function to be called.

I'd prefer the first approach, and don't mind implementing it if all's in consensus.

Thoughts welcome.

@pietern
Copy link
Contributor

pietern commented Apr 21, 2011

This was on my list of things to do for a while and added this today (for the blocking API at least, the async API is a pain since it depends on other libs etc).

@pietern pietern closed this as completed Apr 21, 2011
valentinogeron referenced this issue in RedisLabs/hiredis Feb 20, 2019
fix redisLibeventEvents initialisation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants