-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exit() on OOM #3
Comments
This was on my list of things to do for a while and added this today (for the blocking API at least, the async API is a pain since it depends on other libs etc). |
ghost
mentioned this issue
Oct 3, 2013
This was referenced Oct 16, 2013
ghost
mentioned this issue
Jan 16, 2014
Closed
Closed
Closed
valentinogeron
referenced
this issue
in RedisLabs/hiredis
Feb 20, 2019
fix redisLibeventEvents initialisation
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi
In a few places, if hiredis gets out of memory, it calls exit()
This is unlikely, however since hiredis is a library, I'd like it if program control is dictated by the caller.
I think functions that OOM should just return failure to the user. Alternatively, the user at init time can supply a pointer to his own OOM function to be called.
I'd prefer the first approach, and don't mind implementing it if all's in consensus.
Thoughts welcome.
The text was updated successfully, but these errors were encountered: