Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ Wrapper on hiredis #4

Closed
kappe opened this issue Sep 10, 2010 · 5 comments
Closed

C++ Wrapper on hiredis #4

kappe opened this issue Sep 10, 2010 · 5 comments

Comments

@kappe
Copy link

kappe commented Sep 10, 2010

hi salvatore,

i'm working on a c++ wrapper class upon hiredis (using stl and boost).
i had to make some typecast in the headerfiles of hiredis and leave some compiler options
(new commandline: gcc -fPIC -Wall -Wwrite-strings -O2 -c ...)
do you think this could become problematic?

regards

kappe

@antirez
Copy link
Contributor

antirez commented Sep 16, 2010

Hello,

it seems ok, our goal is that this should compile out of the box on
Linux, *BSD, and Mac OS X.

Cheers,
Salvatore

@pietern
Copy link
Contributor

pietern commented Nov 19, 2010

Can you elaborate on the compiler options that should be left out? The only difference with the options you provide is that the current options have a couple extra warning-related options enabled.

I've just added the commit rtecco/hiredis@8b8aec7b to allow C++ programs to include and use hiredis.

@kappe
Copy link
Author

kappe commented Nov 22, 2010

Hi pietern,

I've build a git repository for my C++ wrapper class on hiredis. I've "patched" hiredis to successfully compile with g++.
See README on https://github.com/kappe/ccredis

Reguards

kappe

@pietern
Copy link
Contributor

pietern commented Nov 22, 2010

If you can outline the changes that are needed (e.g. provide a diff somewhere), then I can check if it is feasible to make changes to the main repo so it compiles with g++. Closing this issue now, because it is no longer an issue.

@kappe
Copy link
Author

kappe commented Nov 23, 2010

I used c++ casts like static_cast<char*>( ).
You can't use in c. So it makes no sense to provide an patch.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants