Handle array response during subscribe in RESP3 #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjosv
force-pushed
the
array-during-subscribe-resp3
branch
from
7e8c3f9 to
af3f432
Compare
|
|
bjosv
force-pushed
the
array-during-subscribe-resp3
branch
from
af3f432 to
7b34aab
Compare
bjosv
force-pushed
the
array-during-subscribe-resp3
branch
from
7b34aab to
49d9824
Compare
RESP3 allows sending commands in parallell with pubsub handling and these commands might get responded with a REDIS_REPLY_ARRAY. This conflicts with the pubsub response handling for RESP2 and results in a faulty state when using RESP3. Add functionality to keep track of PUSH/RESP3 support on the connection and only expect the message type REDIS_REPLY_PUSH as subscribe messages when once seen.
bjosv
force-pushed
the
array-during-subscribe-resp3
branch
from
9b0c433 to
526ef2d
Compare
|
Merged, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RESP3 allows sending commands in parallell with pubsub handling and these commands might get responded with a REDIS_REPLY_ARRAY, like
SORT. This conflicts with the pubsub response handling for RESP2, and triggers asserts when attempting to find the subscribe callback.This PR adds functionality to keep track of PUSH support (RESP3) on the connection to know when replies are subscribe replies.