You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Introducing JedisSocketFactory is a neat idea. However, it raises the question of how addressing should work. Right now, HostAndPort was the only mechanism to obtain a connection. With domain sockets, you need another way to connect to a node. I'd suggest introducing an interface and replace all usages of HostAndPort (breaking change, potentially a 4.0 topic) with that interface. Behind that interface, one can put addressing details so one could e.g. connect to Sentinel using domain sockets (or do other crazy things). You could even have an SSL implementation of JedisSocketFactory that uses SSL details from a SecureHostAndPort.
Introducing
JedisSocketFactory
is a neat idea. However, it raises the question of how addressing should work. Right now,HostAndPort
was the only mechanism to obtain a connection. With domain sockets, you need another way to connect to a node. I'd suggest introducing an interface and replace all usages ofHostAndPort
(breaking change, potentially a 4.0 topic) with that interface. Behind that interface, one can put addressing details so one could e.g. connect to Sentinel using domain sockets (or do other crazy things). You could even have an SSL implementation ofJedisSocketFactory
that uses SSL details from aSecureHostAndPort
.Thanks to @mp911de #2293 (comment)
The text was updated successfully, but these errors were encountered: