Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework/rethink about JedisSocketFactory with HostAndPort #2622

Closed
sazzad16 opened this issue Aug 16, 2021 · 1 comment
Closed

Rework/rethink about JedisSocketFactory with HostAndPort #2622

sazzad16 opened this issue Aug 16, 2021 · 1 comment
Labels

Comments

@sazzad16
Copy link
Collaborator

Introducing JedisSocketFactory is a neat idea. However, it raises the question of how addressing should work. Right now, HostAndPort was the only mechanism to obtain a connection. With domain sockets, you need another way to connect to a node. I'd suggest introducing an interface and replace all usages of HostAndPort (breaking change, potentially a 4.0 topic) with that interface. Behind that interface, one can put addressing details so one could e.g. connect to Sentinel using domain sockets (or do other crazy things). You could even have an SSL implementation of JedisSocketFactory that uses SSL details from a SecureHostAndPort.

Thanks to @mp911de #2293 (comment)

Copy link

github-actions bot commented Jan 3, 2024

This issue is marked stale. It will be closed in 30 days if it is not updated.

@github-actions github-actions bot added the stale label Jan 3, 2024
@github-actions github-actions bot closed this as completed Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant