ClusterPipeline will not return connection when exception happened

[holidayQi]

Expected behavior

I use ClusterPipeline like this

        try (ClusterPipeline clusterPipeline = new ClusterPipeline(clusterConnectionProvider)) {
            List<Response<String>> tmpResults = new ArrayList<>(keys.size());
            keys.forEach(key -> {
                if (key != null) {
                    tmpResults.add(clusterPipeline.get(key));
                } else {
                    tmpResults.add(null);
                }
            });
            clusterPipeline.sync();
            return tmpResults.stream().map(r -> r != null ? r.get() : null).collect(Collectors.toList());
        }

when redis has exception, sync method will not marked synced true

  public final void sync() {
    if (synced) {
      return;
    }
    for (Map.Entry<HostAndPort, Queue<Response<?>>> entry : pipelinedResponses.entrySet()) {
      HostAndPort nodeKey = entry.getKey();
      Queue<Response<?>> queue = entry.getValue();
      List<Object> unformatted = connections.get(nodeKey).getMany(queue.size());
      for (Object o : unformatted) {
        queue.poll().set(o);
      }
    }
    synced = true;
  }

so close will throw exception, and connection will not close

  public void close() {
    sync();
    for (Connection connection : connections.values()) {
      connection.close();
    }
  }

after some time, connection pool will throw 'timeout waiting for idle object'
Is it a problem, or I user it wrong

Actual behavior

return connection even exception happens

Redis / Jedis Configuration

Jedis version: 4.2.2

Redis version:

Java version: jdk 1.8