Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it support asyncio for redis cluster? #2081

Closed
kingluo opened this issue Apr 3, 2022 · 11 comments
Closed

Does it support asyncio for redis cluster? #2081

kingluo opened this issue Apr 3, 2022 · 11 comments
Labels
maintenance Maintenance (CI, Releases, etc)

Comments

@kingluo
Copy link

kingluo commented Apr 3, 2022

It seems that the async version only supports a single Redis instance?

@cpvandehey
Copy link

I can see comments from back in February from folks working on it. I think they originally tried to support clusters, but Im not sure if that was reprioritized.
#1899

@cpvandehey
Copy link

@Andrew-Chen-Wang

@Andrew-Chen-Wang
Copy link
Contributor

Andrew-Chen-Wang commented Apr 5, 2022

No asyncio cluster support yet. Can't remember why I didn't implement it. I don't have the time to check it out again (tho I suppose I can give an hour right now to do it). IIRC I think I did implement it in aioredis. I think it was just a lot of refactoring.

@chayim
Copy link
Contributor

chayim commented Apr 14, 2022

We're almost there... at least for a few modules. @utkarshgupta137 contributed this PR

@agronholm
Copy link
Contributor

agronholm commented May 10, 2022

This was addressed with the addition of redis.asyncio.RedisCluster in v4.3.0, Although it's yet undocumented: https://redis.readthedocs.io/en/latest/connections.html#rediscluster-async

@chayim
Copy link
Contributor

chayim commented May 11, 2022

It's in 4.3.1 @agronholm but we definitely could use a hand with documentation. There was amazing work done by @utkarshgupta137 to get tests in - and they could be the basis for another improvement to our jupyter notebooks. Fancy having a crack at it?

I specifically said to use 4.3.1, since 4.3.0 was broken.

@agronholm
Copy link
Contributor

Fancy having a crack at it?

I'm sorry – I'm neck deep in other F/OSS projects :(

@chayim
Copy link
Contributor

chayim commented May 12, 2022

Alas... had to hope though ;). Thanks anyways @agronholm

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Sep 1, 2022
@XChikuX
Copy link

XChikuX commented Oct 17, 2022

I'd like to use redis with asyncio, is this stable other than the lack of documentation?
If so, I'd be happy to contribute where possible!!

@Andrew-Chen-Wang
Copy link
Contributor

It is stable. Documentation can be found in aioredis documentation. Migrating that would also be appreciated. Note that the commands are the exact same, but they use different clients.

@chayim
Copy link
Contributor

chayim commented Oct 27, 2022

IMHO we should close this. asyncio works in cluster mode, and we have the associated tests. There are missing parity features (RediSearch), but those will land over time.

@chayim chayim closed this as completed Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

No branches or pull requests

6 participants