We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I was just taking a look at the source code and saw this, the condition seems inverted:
redis-py/redis/asyncio/sentinel.py
Lines 222 to 229 in 66a4d6b
In the non-async Sentinel it seems correct: https://github.com/redis/redis-py/blob/master/redis/sentinel.py#L202-L206
If needed, I can help with a PR (I just need to look at the tests to see if we can create one that would catch this).
The text was updated successfully, but these errors were encountered:
@felipou Thanks for reporting this! We are always happy to receive PR's contributions, so go for it...
Sorry, something went wrong.
Ok! I've just created a PR for this: #2718
My PR was merged, so I'm closing this issue! Thanks @dvora-h !
No branches or pull requests
I was just taking a look at the source code and saw this, the condition seems inverted:
redis-py/redis/asyncio/sentinel.py
Lines 222 to 229 in 66a4d6b
In the non-async Sentinel it seems correct:
https://github.com/redis/redis-py/blob/master/redis/sentinel.py#L202-L206
If needed, I can help with a PR (I just need to look at the tests to see if we can create one that would catch this).
The text was updated successfully, but these errors were encountered: