From 8e22b59c78695527aa03950ed112f9bd2b9249ce Mon Sep 17 00:00:00 2001
From: Felipe Machado <462154+felipou@users.noreply.github.com>
Date: Fri, 21 Apr 2023 10:44:22 -0300
Subject: [PATCH] Fix incorrect usage of once flag in async Sentinel

In the execute_command of the async Sentinel, the once flag was being
used incorrectly, with its meaning inverted. To fix we just needed to invert
the if and else bodies. This isn't being caught by the tests currently
because the tests of commands that use this flag do not check their
results/effects (for example the "test_ckquorum" test).
---
 CHANGES                   | 1 +
 redis/asyncio/sentinel.py | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/CHANGES b/CHANGES
index 429045f9a5..d1e4b2aa75 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,4 @@
+    * Fix incorrect usage of once flag in async Sentinel
     * asyncio: Fix memory leak caused by hiredis (#2693)
     * Allow data to drain from async PythonParser when reading during a disconnect()
     * Use asyncio.timeout() instead of async_timeout.timeout() for python >= 3.11 (#2602)
diff --git a/redis/asyncio/sentinel.py b/redis/asyncio/sentinel.py
index ec17886fc6..c3c0f91545 100644
--- a/redis/asyncio/sentinel.py
+++ b/redis/asyncio/sentinel.py
@@ -220,13 +220,13 @@ async def execute_command(self, *args, **kwargs):
             kwargs.pop("once")
 
         if once:
+            await random.choice(self.sentinels).execute_command(*args, **kwargs)
+        else:
             tasks = [
                 asyncio.Task(sentinel.execute_command(*args, **kwargs))
                 for sentinel in self.sentinels
             ]
             await asyncio.gather(*tasks)
-        else:
-            await random.choice(self.sentinels).execute_command(*args, **kwargs)
         return True
 
     def __repr__(self):