Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exclude argocd namespace #1547

Merged
merged 1 commit into from
Mar 7, 2024
Merged

fix: exclude argocd namespace #1547

merged 1 commit into from
Mar 7, 2024

Conversation

j-zimnowoda
Copy link
Contributor

This change ensures that argocd namespace is not included in the set-team-node-affinity of the Assign resource.

@j-zimnowoda j-zimnowoda marked this pull request as draft March 7, 2024 08:02
@j-zimnowoda j-zimnowoda marked this pull request as ready for review March 7, 2024 11:52
ElderMatt
ElderMatt approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@ElderMatt ElderMatt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and the argocd is not stuck on pending any longer

@j-zimnowoda j-zimnowoda merged commit 8a15029 into main Mar 7, 2024
10 checks passed
@j-zimnowoda j-zimnowoda deleted the node-selector branch March 7, 2024 11:55
j-zimnowoda added a commit that referenced this pull request Mar 7, 2024
@j-zimnowoda
fix: exclude argocd namespace from podAffinity mutation (#1547)
611f715 
(cherry picked from commit 8a15029)
j-zimnowoda added a commit that referenced this pull request Mar 7, 2024
@j-zimnowoda
fix: exclude argocd namespace from podAffinity mutation (#1547)
ec0ef6d 
(cherry picked from commit 8a15029)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElderMatt ElderMatt ElderMatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-zimnowoda @ElderMatt