fix: argocd resource values #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merll
requested review from
j-zimnowoda,
dennisvankekem,
srodenhuis and
ferruhcihan
j-zimnowoda
approved these changes
Apr 10, 2024
|
When testing this, I also noticed the default values for the resource limits were not matching in the API, which would set the resource limits too low. Opened PR redkubes/otomi-api#517 for fixing this. |
j-zimnowoda
requested changes
Apr 15, 2024
j-zimnowoda
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the implementation of #1338, the resource values
argocd.resources.[redis,controller,repo,server]were not added to the new templates. Therefore, overrides in the values files have no effect. This PR adds the values to the template.Also the OIDC configuration was partially broken, which was not obvious because oauth2-proxy was handling the login. In this PR also the client secret is inserted correctly and oauth2-proxy is removed from the app, since ArgoCD can handle the login on its own.