Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: schema for harbor databases #1587

Merged
merged 9 commits into from
Apr 19, 2024
Merged

feat: schema for harbor databases #1587

merged 9 commits into from
Apr 19, 2024

Conversation

CasLubbers
Copy link
Contributor

@CasLubbers CasLubbers commented Apr 16, 2024

Notes

Some values that got changed:
type -> useOtomiDB
importedHarborDb -> imported

Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting that out.

During the review I realised that the imported and useOtomiDB are not applicable anymore and could be removed to reduce technical debt. It will also simplify code logic.
Can you perform it in this PR?

helmfile.d/helmfile-04.databases.yaml Outdated Show resolved Hide resolved
helmfile.d/helmfile-04.databases.yaml Show resolved Hide resolved
values-changes.yaml Outdated Show resolved Hide resolved
@j-zimnowoda
Copy link
Contributor

During the upgrade I experience the following issue:

2024-04-19T10:49:54.175Z otomi:cmd:validate-values:validateValues:error {
  keyword: 'additionalProperties',
  dataPath: '/apps/harbor',
  schemaPath: '#/properties/apps/properties/harbor/additionalProperties',
  params: { additionalProperty: 'database' },
  message: 'must NOT have additional properties'
}

Values:
values-redacted-2024-04-19T10_50_21.268Z.yaml.txt

Logs from pipeline
33fd94fd1feee1395f54b26e3776feb9fc9b85d6-gtdxb-otomi-task-pod__step-bootstrap__log.txt

@j-zimnowoda j-zimnowoda self-requested a review April 19, 2024 12:05
Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade succeeded.

@j-zimnowoda j-zimnowoda merged commit 6054f4c into main Apr 19, 2024
10 checks passed
@j-zimnowoda j-zimnowoda deleted the harbor-db-migration branch April 19, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants