From e5bc8361445053cce6f7c1e49ae975cbf2e0f5fd Mon Sep 17 00:00:00 2001 From: Bharath Vissapragada Date: Thu, 7 Mar 2024 13:09:28 -0800 Subject: [PATCH] offline_log_viewer: updates for write caching properties --- tools/offline_log_viewer/controller.py | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/tools/offline_log_viewer/controller.py b/tools/offline_log_viewer/controller.py index ec8abf6747472..8ae7034c680d6 100644 --- a/tools/offline_log_viewer/controller.py +++ b/tools/offline_log_viewer/controller.py @@ -101,7 +101,14 @@ def read_topic_properties_serde(rdr: Reader, version): } if version >= 7: topic_properties |= { - 'mpx_virtual_cluster_id': rdr.read_optional(Reader.read_bytes) + 'mpx_virtual_cluster_id': rdr.read_optional(Reader.read_bytes), + } + + if version >= 8: + topic_properties |= { + 'write_caching': rdr.read_optional(Reader.read_serde_enum), + 'flush_ms': rdr.read_optional(Reader.read_int64), + 'flush_bytes': rdr.read_optional(Reader.read_int64) } return topic_properties @@ -123,7 +130,7 @@ def read_topic_configuration_assignment_serde(rdr: Reader): rdr.read_int16(), 'properties': rdr.read_envelope(read_topic_properties_serde, - max_version=7), + max_version=8), }, 1), 'assignments': rdr.read_serde_vector(lambda r: r.read_envelope( @@ -246,10 +253,16 @@ def incr_topic_upd(rdr: Reader, version): read_property_update_serde( rdr, lambda r: r.read_tristate(Reader.read_uint64)) } + if version >= 6: + incr_obj |= { + 'write_caching': rdr.read_optional(Reader.read_serde_enum), + 'flush_ms': rdr.read_optional(Reader.read_int64), + 'flush_bytes': rdr.read_optional(Reader.read_int64) + } return incr_obj - return rdr.read_envelope(incr_topic_upd, max_version=5) + return rdr.read_envelope(incr_topic_upd, max_version=6) def read_create_partitions_serde(rdr: Reader):