From aba90afb53736add657cb414912c8aaf767e8592 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Ma=C5=9Blanka?= Date: Thu, 12 Dec 2024 17:51:52 +0100 Subject: [PATCH 1/3] r/buffered_protocol: added a missing call to setup metrics MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Michał Maślanka --- src/v/raft/buffered_protocol.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/v/raft/buffered_protocol.cc b/src/v/raft/buffered_protocol.cc index 44d4849345bcd..c662bbacb9b20 100644 --- a/src/v/raft/buffered_protocol.cc +++ b/src/v/raft/buffered_protocol.cc @@ -253,6 +253,7 @@ append_entries_queue::append_entries_queue( } _current_max_inflight_requests = new_value; }); + setup_internal_metrics(); // start dispatch loop ssx::repeat_until_gate_closed( _gate, From 710449fd0ac3eac5847d8ddce993bee7acac2a11 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Ma=C5=9Blanka?= Date: Fri, 13 Dec 2024 11:20:56 +0100 Subject: [PATCH 2/3] r/buffered_protocol: removed double colons in metric names MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Michał Maślanka --- src/v/raft/buffered_protocol.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/v/raft/buffered_protocol.cc b/src/v/raft/buffered_protocol.cc index c662bbacb9b20..60c96d2bf650a 100644 --- a/src/v/raft/buffered_protocol.cc +++ b/src/v/raft/buffered_protocol.cc @@ -358,7 +358,7 @@ void append_entries_queue::setup_internal_metrics() { } sm::label_instance target_node_id_label("target_node_id", _target_node); _internal_metrics.add_group( - prometheus_sanitize::metrics_name("raft::buffered::protocol"), + prometheus_sanitize::metrics_name("raft:buffered:protocol"), {sm::make_gauge( "inflight_requests", [this] { return inflight_requests(); }, From e80fbd69f9b8103d5720266a0fd02ba856ffbfaa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Ma=C5=9Blanka?= Date: Fri, 13 Dec 2024 11:21:53 +0100 Subject: [PATCH 3/3] r/buffered_protocol: removed append entries latency histogram MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We already track RPC methods latency so the histogram can be removed. Signed-off-by: Michał Maślanka --- src/v/raft/buffered_protocol.cc | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/v/raft/buffered_protocol.cc b/src/v/raft/buffered_protocol.cc index 60c96d2bf650a..aa1a312493ab8 100644 --- a/src/v/raft/buffered_protocol.cc +++ b/src/v/raft/buffered_protocol.cc @@ -375,12 +375,7 @@ void append_entries_queue::setup_internal_metrics() { [this] { return _requests.size(); }, sm::description( "Total number of append entries requests in the queue"), - {target_node_id_label}), - sm::make_histogram( - "append_entries_request_latency", - sm::description("Latency of append entries requests"), - {target_node_id_label}, - [this] { return _hist.internal_histogram_logform(); })}); + {target_node_id_label})}); } void append_entries_queue::setup_public_metrics() {