Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ES build comaptibility #386

Merged
merged 9 commits into from
Jan 22, 2023

Conversation

alexander-heimbuch
Copy link
Contributor

First of all I really love this package and it is one of the must have packages for every redux stack I'm working on <3 Since I'm moving most of my projects to Vite I had some troubles with peer dependencies in this project (invariant) so I made some adjustments to make it more ES friendly and internalised the dependency.

I also streamlined some build tooling and added some exports to the build process.

Copy link
Member

@timche timche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Few minor comments.

Other:

  • .DS_Store should not be included and maybe be ignored with .gitignore
  • We could reconsider the usage of Codecov and either keep it, replace it or remove code coverage completely

.travis.yml Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
Copy link
Member

@timche timche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job! 👏

@alexander-heimbuch alexander-heimbuch merged commit f9d655c into redux-utilities:master Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants