Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing mapStateToProps doesn't hot reload? #115

Closed
ronag opened this issue Sep 20, 2015 · 5 comments
Closed

Changing mapStateToProps doesn't hot reload? #115

ronag opened this issue Sep 20, 2015 · 5 comments

Comments

@ronag
Copy link

ronag commented Sep 20, 2015

Not sure if this is expected or not. But when updating mapStateToProps components don't seem to re-execute the mapStateToProps function.

@gaearon
Copy link
Contributor

gaearon commented Sep 21, 2015

Yeah, with the tooling overhaul it's a bit of grey area right now. Let's keep it open.

@gaearon
Copy link
Contributor

gaearon commented Sep 23, 2015

Let's track this in gaearon/babel-plugin-react-transform#26 instead. You can also keep using React Hot Loader until it is fixed. With React Hot Loader, mapStateToProps should get reloaded just fine. When the issue in Babel plugin is fixed, it will work with React Transform too.

@gaearon
Copy link
Contributor

gaearon commented Feb 29, 2016

You might be interested in reduxjs/redux#1455.

@gaearon
Copy link
Contributor

gaearon commented Apr 18, 2016

This is fixed in React Hot Loader 3.
It is built with lessons learned from both React Hot Loader and React Transform.
It’s still in alpha but I encourage you to check it out!

@glenjamin
Copy link

This is fixed in React Hot Loader 3.
It is built with lessons learned from both React Hot Loader and React Transform.
It’s still in alpha but I encourage you to check it out!

@gaearon Great stuff! ran into this today when teaching redux to someone. I'll give it a whirl :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants