-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bikeshed discussion: naming and marketing, again #246
Comments
How hard would it be to achieve including it with tree shaking? That would be my vote if that was achievable. If not, I would vote for don't rename. |
I see no downside to merging into core, if tree-shaking is possible. Without tree-shaking it's probably not an option. Second best would be using the @Redux scope, as it shows right away its an official redux lib. @redux/starter-kit or @redux/toolkit sounds good. |
There are at least a couple potential technical issues with merging everything into the core:
We do currently own the |
Use apollo-boost as your guide. Drop the word “starter”. Apollo’s docs make no bones about boost. They don’t offer it as an option. From the get-go they say that boost is how you use apollo, and only mention the non-boost methodology later. They go all in on boost because for most people it will suffice, and you won’t even know when it won’t suffice until you hit those situations. You have to make a decision about how important this kit is. If you want more people to use it, make it sound like it’s the best way to use redux for most situations and only in specific cases would you want to go custom, with instructions on how to import all the individual pieces separately, just like boost. Check out this page to see what I mean: Note that they use the term “starter kit” in the docs, but not in the actual name of the library. They clearly had this conversation prior to releasing it and came to the same conclusion you reached the hard way. 😉 |
As I think scoping would be the way to go, to make it stand out from all the non-official redux boilerplate toolkits (you noticed how it's received if you're not saying that "it's official" in this thread, didn't you?), I'll suggest to split that option up:
|
Unfortunately it seems to be the word "starter" that's throwing everyone off, so if we're gonna rename it, that's gotta go. |
Looking through https://twitter.com/acemarke/status/1190296894494388229 and https://twitter.com/acemarke/status/1191518131765821443 , here's a list of all the proposed names (even the silly ones). Repeated suggestions counted in parentheses:
The ones that actually have multiple votes are:
And as one person pointed out, a search for There is an existing So yeah, if we were going to rename it, it seems like Here's the obligatory Twitter poll on renaming options: |
Okay, so let's discuss what would actually be needed to do this migration. We would need to:
Anything else? The other complication is that #226 is in the process of trying to switch the docs site over to Docusaurus v2. edit Oh. We'd have to re-create all the tutorial repos and sandboxes, again. Oops. |
We'll need a version bump (patch/minor/major?) of the old package name that either
|
Another line of thought on naming suggestions : Any good words that start with 'S' and go well with "Kit", to keep the RSK acronym? Or, another suggestion that popped into my head : "Redux Standard Toolkit" / |
Forget about SEO, that doesn’t matter. It’s already been established that the current name is unpopular and confusing so what’s the benefit to hanging on to it? None. This is a rebranding. Start fresh. Names that are unique and sticky are better than ones that are descriptive and accurate. Fire |
I wouldn't say that the name is unpopular, just that the "starter" term is confusing people. I would like any new name to be meaningful (ie, not a random code word), and ideally as similar as possible to the existing name. "Redux Toolkit" seems to be the best option at this point. |
@MPLIS : honestly, I'm against |
also, in Apollo's case, apollo-boost REALLY is a starter kit. You quickly find out you need to ditch it if you need more control over the lib. I think that's the exact mentality we are trying to avoid here. |
I thought I'd throw my 2c in since I made one of the Twitter comments you quoted above. I honestly think If you do decide to change the name then one I like best is I don't like "boost" because it assumes that I know what a "boost" or an Apollo is :-). It's adding another terminology dependency that may not be ubiquitous enough. |
Oh, to add another thing: Initially, I didn't think that "starter" would confuse ppl too much. Until last week a team member told me that it had confused him when I added RSK to the project, because surely, we need no starter kit. |
I'm following this from the very first tweet and yes, I was initially throwed off by the "starter" word too. |
It'd be nice to keep the "RSK" acronym, but I could live with "RTK" for "Redux Toolkit". |
👍 For |
@RichiCoder1 : hmm. That's an interesting suggestion, actually. The immediate issues I see are:
I suppose we could duplicate some of the content, maybe, kind of like how we cover some of the React-Redux API and usage in the core docs. That might be a reasonable approach - have an additional category for RTK, duplicate some of the API and usage stuff, and point to the actual RTK docs for the complete coverage. Thanks for the idea! |
Opened an issue to ask about migrating the |
Opened a new issue to track the actual migration process: #248 |
Having established that, I'm still looking for suggestions on a good marketing / sales pitch summary sentence. I've been using different variations, and it'd be nice to have a single consistent one. Phrases I've used so far:
Also, my typical paragraph description:
Any better suggestions? |
Something around the "Reduction and elimination of common Redux boilerplate like action creators and action types". Eliminating boilerplate is what hooked me. |
I'd err away from "simple" for the short descriptions, if only since that might convey the same issues that docs have with the word "just". That said, I really like batteries included and opinionated as descriptors, as that's often what statements critical of Redux zero in on. For the paragraph description, I think that's a great sell to existing Redux users, but makes a lot of prerequisite knowledge assumptions that might drive away beginners and skeptics. Maybe something like:
|
More of a brain dump, but something along the lines of:
or maybe just:
|
Hmm. Maybe:
Could drop "opinionated" out of there, or say "efficient" instead of "streamlined". |
Or possible drop both:
Succinct and mostly objective? In fact, maybe even:
Which is fully succinct and objective? |
And the migration is basically done! New package is published, repo and website have been renamed, and the docs have been mostly updated. I still need to rework the RTK tutorial repos and sandboxes, and clean up some other bits. But, not bad for one night :) I settled on a sales pitch phrase of:
Since this is basically done, I'll go ahead and close the issue. Thanks for all the feedback - now go migrate your apps over to RTK :) |
Issue Update
The current plan is to rename the RSK package to "Redux Toolkit" /
@reduxjs/toolkit
. See #248 for current migration status.Original Post
Back in #36 , we debated name options for a while. We settled on
redux-starter-kit
because that's basically what we already had (@acemarke/redux-starter-kit
, which itself came from reduxjs/redux#2859 ), and the NPM package name was donated to us in that thread.Unfortunately, I'm seeing a lot of folks say that they didn't even want to look at the lib, because the name "starter" suggests it's only good for beginners, like these examples:
I don't want to rename RSK, but clearly the name is throwing people off, and that concerns me.
I tried asking about ways to improve the marketing, and mostly got a bunch of random name suggestions.
Soooo... I'm gonna open this up for discussion again, and ask if we should seriously consider renaming RSK to something else, and if so, what.
Overall, the options are:
@reduxjs/
Pros and cons:
react-testing-library
Merging RSK into the core is highly unlikely, and @timdorr has said he's against that. Still, it's a hypothetical option.
If we were going to rename it, my inclination would be something like
@reduxjs/toolkit
.Thoughts?
The text was updated successfully, but these errors were encountered: