Fix all uses of /dist/ in type imports

[markerikson]

Per Andrew Branch, these are bad and breaking things:

import type { Api } from '@reduxjs/toolkit/dist/query/apiTypes'

import type {
  QuerySubState,
  SubscriptionOptions,
  QueryKeys,
  RootState,
} from '@reduxjs/toolkit/dist/query/core/apiState'

// etc

They should just import from the packages instead, like @reduxjs/toolkit/query.

[eric-crowell]

Would it be preferred to use relative pathing to these types instead of from the package's main export?
Otherwise, all those types would also have to be publicly exported and supported? (I think, maybe I'm wrong)

Wanted to ask since I was already patching a lot of this to fix my projects using 2.0. Hoping I can put out a PR for this issue.

[phryneas]

@eric-crowell That would lead the packages to merge into each other at bundling, which you definitely don't want to happen.

[eric-crowell]

@eric-crowell That would lead the packages to merge into each other at bundling, which you definitely don't want to happen.

Ah, okay. I agree, I definitely don't want that to happen. Will keep with the suggested fix if I can make a PR.

[eric-crowell]

@phryneas As I'm working this, I'm not sure how to import these without relative pathing or exposing them publicly.

With ESM, @reduxjs/toolkit looks like a single package with different entry points now. So maybe bundling together isn't bad? I know Vite is pretty smart with bundling shared resources per entry point (with relative imports). For type imports, I don't think they'll be any bundling. Just need to make sure there's nothing circular.

How should I approach?

[markerikson]

Done in #3672 .