From 8466e752f637403c4f0b440928385ca51d136bcf Mon Sep 17 00:00:00 2001 From: Tobbe Lundberg Date: Sat, 6 Jan 2024 13:20:00 +0100 Subject: [PATCH 1/2] chore(ci): Update task names to say "node 20" (#9805) --- .github/workflows/ci.yml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 61c51cbebd7a..336f8f802a1f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -90,7 +90,7 @@ jobs: matrix: os: [ubuntu-latest, windows-latest] - name: 🏗 Build, lint, test / ${{ matrix.os }} / node 18 latest + name: 🏗 Build, lint, test / ${{ matrix.os }} / node 20 latest runs-on: ${{ matrix.os }} steps: @@ -144,7 +144,7 @@ jobs: matrix: os: [ubuntu-latest, windows-latest] - name: 🏗 Build, lint, test / ${{ matrix.os }} / node 18 latest + name: 🏗 Build, lint, test / ${{ matrix.os }} / node 20 latest runs-on: ${{ matrix.os }} steps: @@ -157,7 +157,7 @@ jobs: matrix: bundler: [vite, webpack] - name: 🌲 Tutorial E2E / ${{ matrix.bundler }} / node 18 latest + name: 🌲 Tutorial E2E / ${{ matrix.bundler }} / node 20 latest runs-on: ubuntu-latest steps: @@ -235,7 +235,7 @@ jobs: matrix: bundler: [vite, webpack] - name: 🌲 Tutorial E2E / ${{ matrix.bundler }} / node 18 latest + name: 🌲 Tutorial E2E / ${{ matrix.bundler }} / node 20 latest runs-on: ubuntu-latest steps: @@ -249,7 +249,7 @@ jobs: os: [ubuntu-latest, windows-latest] bundler: [vite, webpack] - name: 🔄 Smoke tests / ${{ matrix.os }} / ${{ matrix.bundler }} / node 18 latest + name: 🔄 Smoke tests / ${{ matrix.os }} / ${{ matrix.bundler }} / node 20 latest runs-on: ${{ matrix.os }} env: @@ -427,7 +427,7 @@ jobs: # # ``` # env: - # RECORD_REPLAY_METADATA_TEST_RUN_TITLE: 🔄 Smoke tests / ${{ matrix.os }} / node 18 latest + # RECORD_REPLAY_METADATA_TEST_RUN_TITLE: 🔄 Smoke tests / ${{ matrix.os }} / node 20 latest # RECORD_REPLAY_TEST_METRICS: 1 # ``` # @@ -446,7 +446,7 @@ jobs: os: [ubuntu-latest, windows-latest] bundler: [vite, webpack] - name: 🔄 Smoke tests / ${{ matrix.os }} / ${{ matrix.bundler }} / node 18 latest + name: 🔄 Smoke tests / ${{ matrix.os }} / ${{ matrix.bundler }} / node 20 latest runs-on: ${{ matrix.os }} steps: @@ -459,7 +459,7 @@ jobs: matrix: os: [ubuntu-latest, windows-latest] - name: 🔭 Telemetry check / ${{ matrix.os }} / node 18 latest + name: 🔭 Telemetry check / ${{ matrix.os }} / node 20 latest runs-on: ${{ matrix.os }} env: @@ -506,7 +506,7 @@ jobs: matrix: os: [ubuntu-latest, windows-latest] - name: 🔭 Telemetry check / ${{ matrix.os }} / node 18 latest + name: 🔭 Telemetry check / ${{ matrix.os }} / node 20 latest runs-on: ${{ matrix.os }} steps: From 6fbc5b837c1a19d6989dca8480f1abfe48d5f326 Mon Sep 17 00:00:00 2001 From: Tobbe Lundberg Date: Sat, 6 Jan 2024 14:33:01 +0100 Subject: [PATCH 2/2] chore(cli): More robust isAwaitable (#9806) --- tasks/test-project/typing.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tasks/test-project/typing.ts b/tasks/test-project/typing.ts index 9528b57ef432..d4b15fb30e89 100644 --- a/tasks/test-project/typing.ts +++ b/tasks/test-project/typing.ts @@ -17,5 +17,10 @@ export interface TuiTaskDef { } export function isAwaitable(promise: unknown): promise is Promise { - return typeof promise !== 'undefined' && 'then' in promise + return ( + !!promise && + typeof promise === 'object' && + 'then' in promise && + typeof promise.then === 'function' + ) }