Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Routes eslint targets too many elements #10383

Closed
dac09 opened this issue Mar 31, 2024 · 0 comments · Fixed by #10404
Closed

[Bug]: Routes eslint targets too many elements #10383

dac09 opened this issue Mar 31, 2024 · 0 comments · Fixed by #10404
Assignees
@dac09

Comments

@dac09
Copy link
Contributor

dac09 commented Mar 31, 2024

In packages/eslint-plugin/src/tests/unsupported-route-components.test.ts our linting is too broad, it targets all JSX opening elements.

Image

Expected behaviour:
If you use any other elements outside the Route tree it should not throw a linting error or warning
@dac09 dac09 self-assigned this Mar 31, 2024
@dac09 dac09 converted this from a draft issue Mar 31, 2024
@dac09 dac09 moved this from In Progress to Todo in Bighorn Development Archive Apr 1, 2024
@dac09 dac09 moved this from Todo to In Progress in Bighorn Development Archive Apr 3, 2024
@dac09 dac09 mentioned this issue Apr 3, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Bighorn Development Archive Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dac09 dac09

Labels
None yet
Projects
No open projects
Bighorn Development Archive
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rw-eslint): Implement more specific checking on Routes dac09/redwood
1 participant
@dac09