From 7d96ef7beba510b28f779b39ea4f406b81201c4b Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 18 Dec 2018 23:05:18 -0800 Subject: [PATCH] lib: make internal API warning more direct Before: These APIs are exposed only for testing and are not tracked by any versioning system or deprecation process. After: These APIs are for internal testing only. Do not use them. PR-URL: https://github.com/nodejs/node/pull/25125 Reviewed-By: Joyee Cheung Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Jeremiah Senkpiel Reviewed-By: Daijiro Wachi Reviewed-By: Ruben Bridgewater Reviewed-By: Luigi Pinca --- lib/internal/test/binding.js | 3 +-- lib/internal/test/heap.js | 3 +-- test/parallel/test-dns-lookup.js | 3 +-- test/parallel/test-fs-filehandle.js | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/lib/internal/test/binding.js b/lib/internal/test/binding.js index 17f1574efc7b98..882ea90093d039 100644 --- a/lib/internal/test/binding.js +++ b/lib/internal/test/binding.js @@ -1,8 +1,7 @@ 'use strict'; process.emitWarning( - 'These APIs are exposed only for testing and are not ' + - 'tracked by any versioning system or deprecation process.', + 'These APIs are for internal testing only. Do not use them.', 'internal/test/binding'); module.exports = { internalBinding }; diff --git a/lib/internal/test/heap.js b/lib/internal/test/heap.js index 61fe5916fd7584..3f4a905fc51836 100644 --- a/lib/internal/test/heap.js +++ b/lib/internal/test/heap.js @@ -1,8 +1,7 @@ 'use strict'; process.emitWarning( - 'These APIs are exposed only for testing and are not ' + - 'tracked by any versioning system or deprecation process.', + 'These APIs are for internal testing only. Do not use them.', 'internal/test/heap'); const { createHeapDump, buildEmbedderGraph } = internalBinding('heap_utils'); diff --git a/test/parallel/test-dns-lookup.js b/test/parallel/test-dns-lookup.js index b30c5795feb31a..3da4e9f58db95c 100644 --- a/test/parallel/test-dns-lookup.js +++ b/test/parallel/test-dns-lookup.js @@ -24,8 +24,7 @@ cares.getaddrinfo = () => internalBinding('uv').UV_ENOENT; common.expectWarning({ // For 'internal/test/binding' module. 'internal/test/binding': [ - 'These APIs are exposed only for testing and are not ' + - 'tracked by any versioning system or deprecation process.' + 'These APIs are for internal testing only. Do not use them.' ], // For dns.promises. 'ExperimentalWarning': [ diff --git a/test/parallel/test-fs-filehandle.js b/test/parallel/test-fs-filehandle.js index 57bdc43bee0d2d..a56b39f7c92526 100644 --- a/test/parallel/test-fs-filehandle.js +++ b/test/parallel/test-fs-filehandle.js @@ -21,8 +21,7 @@ let fdnum; common.expectWarning({ 'internal/test/binding': [ - 'These APIs are exposed only for testing ' + - 'and are not tracked by any versioning system or deprecation process.', + 'These APIs are for internal testing only. Do not use them.', common.noWarnCode ], 'Warning': [